Initialize statement codecs immediately after Prepare #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
approved these changes
Jan 20, 2018
Currently the statement codecs are populated just before the first Bind is issued. This is problematic as in the time since Prepare, the codec cache for derived types (arrays, composites etc.) may have been purged by an installation of a custom codec, or general schema state invalidation. Fix this by populating the codecs immediately after the statement data types have been resolved. Fixes: #241.
elprans
force-pushed
the
fix-stmtstate-codec-race
branch
from
4bdb32a to
f789131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the statement codecs are populated just before the first Bind
is issued. This is problematic as in the time since Prepare, the codec
cache for derived types (arrays, composites etc.) may have been purged
by an installation of a custom codec, or general schema state
invalidation.
Fix this by populating the codecs immediately after the statement data
types have been resolved.
Fixes: #241.